Added the List component to the sistent components page and updated the content.js file.#6219
Added the List component to the sistent components page and updated the content.js file.#6219csengineer1990 wants to merge 17 commits intolayer5io:masterfrom
Conversation
…he content.js Signed-off-by: Roshan Goswami <csengineer23@gmail.com>
|
🚀 Preview for commit 5c557f3 at: https://679f638e6e5e0b86aee4c955--layer5.netlify.app |
|
@csengineer1990 adding it as an agenda item to the meeting minutes. |
There was a problem hiding this comment.
Not require to create a separate file for code-block.js you can directly import, so delete this file
There was a problem hiding this comment.
Can you include example for the List controls like checkbox?
Vidit-Kushwaha
left a comment
Vidit-Kushwaha
left a comment
There was a problem hiding this comment.
I have provided few feedback can you look @csengineer1990
| import React, { useState } from "react"; | ||
| import Code from "../../../../../components/CodeBlock"; | ||
|
|
||
| export const CodeBlock = ({ name, code }) => { |
There was a problem hiding this comment.
use existing codeblock and don't create a new one please
Signed-off-by: Roshan Goswami <csengineer23@gmail.com>
…oned in the previous request. Signed-off-by: Roshan Goswami <csengineer23@gmail.com>
|
Made the requested changes by adding examples of List control with checkboxes and removing code-block.js. Apologies for the delayed update. If any further changes are needed, please let me know. |
|
🚀 Preview for commit 2a9bd74 at: https://67b08c32b7f3d319c41cfb1e--layer5.netlify.app |
|
@csengineer1990 please have a look at the merge conflicts here. |
Yes, I will surely resolve the merge conflicts as soon as possible. Thanks for bringing it to my attention! |
Signed-off-by: Roshan Goswami <csengineer23@gmail.com>
Signed-off-by: Roshan <68468678+csengineer1990@users.noreply.github.com>
|
🚀 Preview for commit fefa978 at: https://67b954e04b59d7b097203a3b--layer5.netlify.app |
|
I have resolved the merge conflict. Please review the commit and let me know if there are any issues so that I can address them as soon as possible. |
Vidit-Kushwaha
left a comment
Vidit-Kushwaha
left a comment
There was a problem hiding this comment.
Approved 👍
Add this as an agenda item to the meeting minutes.
|
I have resolved the merge conflict. Please review the commit and let me know if there are any issues so that I can address them as soon as possible. |
Hi, I’ve resolved the merge conflict and pushed the updated commit. |
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: l5io <ci@layer5.io>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: l5io <ci@layer5.io>
|
Hey @csengineer1990, Is this done from your side? |
stale
bot
removed
the
issue/stale
Signed-off-by: l5io <ci@layer5.io>
Hi, I had completed this issue earlier and at that time everything was working fine. I haven’t re-downloaded the repo recently, but from the GitHub checks it looks like there are no merge conflicts and the branch can be merged. Please let me know if you still need me to make any additional updates. |
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: l5io <ci@layer5.io>
|
any updates ? |
|
Due to unwanted changes in |
8 participants
Description
This PR addresses issue #5951 by adding the List component to the Sistent Components page. The necessary content and documentation for the List component have been included, along with updates to the relevant files to ensure consistency.
This PR fixes #5951
Notes for Reviewers
I have made the following changes:
I have made the required changes as requested in the previous reviews and aligned them with the issue to ensure a proper resolution.
I would appreciate your review of these updates. Please let me know if any further refinements or additional changes are needed. Thank you!
Signed commits